Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): change TypeScript version range to >=3.2.1 <3.5.0 #399

Merged
merged 3 commits into from Apr 3, 2019

Conversation

Projects
None yet
1 participant
@JamesHenry
Copy link
Member

JamesHenry commented Apr 3, 2019

TypeScript version added by this PR: 3.4.x

  • I have updated the devDependency range in the root package.json
  • I have updated the range value in packages/typescript-estree/src/parser.ts
  • I have run the existing tests to make sure they still pass, or made any required updates
  • I have added new tests for the features introduced in this newer version of TypeScript
  • New feature tests added:
    • const assertions
    • readonly array alternate syntax
    • readonly tuples

@JamesHenry JamesHenry force-pushed the ts-3.4 branch from a2506a1 to f2ef272 Apr 3, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #399 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #399   +/-   ##
======================================
  Coverage    97.2%   97.2%           
======================================
  Files          68      68           
  Lines        2507    2507           
  Branches      388     388           
======================================
  Hits         2437    2437           
  Misses         44      44           
  Partials       26      26
Impacted Files Coverage Δ
packages/typescript-estree/src/node-utils.ts 98.63% <ø> (ø) ⬆️
packages/eslint-plugin/src/util/createRule.ts 100% <ø> (ø) ⬆️
packages/typescript-estree/src/parser.ts 93.06% <100%> (ø) ⬆️

James Henry added some commits Apr 3, 2019

James Henry
James Henry

@JamesHenry JamesHenry merged commit a4f95d3 into master Apr 3, 2019

3 checks passed

Semantic Pull Request ready to be squashed
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 97.2% (+0%) compared to 5d81f8c
Details

@JamesHenry JamesHenry deleted the ts-3.4 branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.