Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [typedef] fix regression with class properties #4034

merged 1 commit into from Oct 20, 2021


Copy link

Fixes #4033

@bradzacher bradzacher added the bug Something isn't working label Oct 20, 2021
Copy link

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #4034 (d7f3236) into master (600d413) will increase coverage by 0.62%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4034      +/-   ##
+ Coverage   92.69%   93.32%   +0.62%     
  Files         333      151     -182     
  Lines       11400     7937    -3463     
  Branches     3242     2545     -697     
- Hits        10567     7407    -3160     
+ Misses        363      180     -183     
+ Partials      470      350     -120     
Flag Coverage Δ
unittest 93.32% <100.00%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/typedef.ts 94.52% <100.00%> (+2.73%) ⬆️
... and 174 more

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

[@typescript-eslint/typedef] In the class, even if there are types, there will still check not passed
1 participant