Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify git hooks #445

Merged
merged 1 commit into from Apr 20, 2019

Conversation

Projects
None yet
2 participants
@bradzacher
Copy link
Member

commented Apr 19, 2019

Closes #259

We have too many tests to run at commit time now.
I would also say that there are too many to run at push time, as well.
Our CI will run all of the tests (incl integration tests), so there's no need to force contributors to wait through a full test cycle every commit/push.

  • change pre-commit hook to only run prettier.
    • commit hooks are used regularly, so we want it to be as lightweight as possible.
  • add pre-push hook which runs lint + typecheck + format.
    • these are all much heavier (total i find takes ~30-40s), but I think it's good to try and block pushes because of these - some of the most common errors I see are lint problems or unformatted files.

My question (for @JamesHenry, who I think added it?), is do we need commitizen? It's just admins that can push to master, otherwise all branch commits are hidden behind a squashed PR message (which is enforced via one of the PR status checks) - so enforcing a commit message style on the client seems unnecessary?

@bradzacher bradzacher force-pushed the cleanup-hooks branch from 69486fd to 5ace5d8 Apr 19, 2019

@JamesHenry JamesHenry merged commit 9559323 into master Apr 20, 2019

8 checks passed

Semantic Pull Request ready to be squashed
Details
codecov/patch Coverage not affected when comparing 6c50a99...5ace5d8
Details
codecov/project 97.14% remains the same compared to 6c50a99
Details
typescript-eslint.typescript-eslint Build #20190419.5 succeeded
Details
typescript-eslint.typescript-eslint (Primary code validation and tests) Primary code validation and tests succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_10_x) Run unit tests on other Node.js versions node_10_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_6_x) Run unit tests on other Node.js versions node_6_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_8_x) Run unit tests on other Node.js versions node_8_x succeeded
Details

@JamesHenry JamesHenry deleted the cleanup-hooks branch Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.