Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add new 'strict' config #4706

Merged
merged 25 commits into from May 16, 2022

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 21, 2022

PR Checklist

Overview

Adds a new 'strict' level for the recommended metadata for rules. It indicates to include the rule in a new plugin:@typescript-eslint/strict config.

Putting this PR up now as a draft as reference for #4648 before fleshing out docs.

@nx-cloud
Copy link

nx-cloud bot commented Mar 21, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit be77517. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Mar 21, 2022

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Mar 21, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit be77517
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62818e854c97ba00084a725e
😎 Deploy Preview https://deploy-preview-4706--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #4706 (be77517) into main (77e15a9) will increase coverage by 1.44%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4706      +/-   ##
==========================================
+ Coverage   92.64%   94.08%   +1.44%     
==========================================
  Files         190      161      -29     
  Lines       10251     8559    -1692     
  Branches     3249     2770     -479     
==========================================
- Hits         9497     8053    -1444     
+ Misses        502      285     -217     
+ Partials      252      221      -31     
Flag Coverage Δ
unittest 94.08% <100.00%> (+1.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/array-type.ts 97.18% <ø> (ø)
...ages/eslint-plugin/src/rules/ban-tslint-comment.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/ban-types.ts 100.00% <ø> (ø)
...t-plugin/src/rules/class-literal-property-style.ts 100.00% <ø> (ø)
...lugin/src/rules/consistent-indexed-object-style.ts 92.06% <ø> (ø)
...int-plugin/src/rules/consistent-type-assertions.ts 88.88% <ø> (ø)
...nt-plugin/src/rules/consistent-type-definitions.ts 97.29% <ø> (ø)
packages/eslint-plugin/src/rules/dot-notation.ts 96.29% <ø> (ø)
...kages/eslint-plugin/src/rules/no-base-to-string.ts 98.41% <ø> (ø)
...lugin/src/rules/no-confusing-non-null-assertion.ts 82.60% <ø> (ø)
... and 57 more

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review Apr 8, 2022
@bradzacher bradzacher added the recommended-rules label Apr 8, 2022
bradzacher
bradzacher previously approved these changes Apr 9, 2022
docs/linting/PRESETS.md Outdated Show resolved Hide resolved
packages/eslint-plugin/docs/rules/TEMPLATE.md Outdated Show resolved Hide resolved
packages/eslint-plugin/src/configs/strict.ts Show resolved Hide resolved
packages/eslint-plugin/src/configs/strict.ts Show resolved Hide resolved
bradzacher
bradzacher previously approved these changes Apr 18, 2022
Copy link
Member

@bradzacher bradzacher left a comment

LGTM!

@bradzacher bradzacher added the 1 approval label Apr 22, 2022
@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: add new 'strict' config feat(eslint-plugin): add new 'strict' config May 15, 2022
bradzacher
bradzacher previously approved these changes May 15, 2022
@bradzacher
Copy link
Member

bradzacher commented May 15, 2022

feel free to admin merge once you've got this finalised - i'm happy with what you've got!

@JoshuaKGoldberg
Copy link
Contributor Author

JoshuaKGoldberg commented May 15, 2022

My main hesitation against pushing this is that we don't have a blog to nicely announce it on yet (#4957) 😂. But that's not a good reason. We can always posthumously write a blog post for this PR.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4a500b2 into typescript-eslint:main May 16, 2022
20 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the strict-config branch May 16, 2022
extends: [
...EXTENDS,
'./configs/recommended',
'./configs/recommended-requiring-type-checking',
Copy link
Contributor Author

@JoshuaKGoldberg JoshuaKGoldberg May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hey I think I'd meant to leave this out.

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this issue May 19, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.23.0` -> `5.25.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.23.0/5.25.0) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.23.0` -> `5.25.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.23.0/5.25.0) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.25.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5250-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5240v5250-2022-05-17)

[Compare Source](typescript-eslint/typescript-eslint@v5.24.0...v5.25.0)

##### Bug Fixes

-   **eslint-plugin:** \[typedef] stop enforcing rule for assignment expressions ([#&#8203;4958](typescript-eslint/typescript-eslint#4958)) ([04a216c](typescript-eslint/typescript-eslint@04a216c))
-   **eslint-plugin:** strict config should not extend recommended ([#&#8203;5005](typescript-eslint/typescript-eslint#5005)) ([05d71c2](typescript-eslint/typescript-eslint@05d71c2))
-   **website:** correct Presets link to be Configs ([#&#8203;5004](typescript-eslint/typescript-eslint#5004)) ([e18e91c](typescript-eslint/typescript-eslint@e18e91c))

##### Features

-   **eslint-plugin:** \[no-empty-function] new allow option overrideMethods ([#&#8203;4923](typescript-eslint/typescript-eslint#4923)) ([13c05ae](typescript-eslint/typescript-eslint@13c05ae))
-   **eslint-plugin:** deprecate `no-duplicate-imports` in favour of `import/no-duplicates` ([#&#8203;4973](typescript-eslint/typescript-eslint#4973)) ([1d2e41a](typescript-eslint/typescript-eslint@1d2e41a))
-   update to TypeScript 4.7-rc ([#&#8203;4829](typescript-eslint/typescript-eslint#4829)) ([6fe783c](typescript-eslint/typescript-eslint@6fe783c))

### [`v5.24.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5240-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5230v5240-2022-05-16)

[Compare Source](typescript-eslint/typescript-eslint@v5.23.0...v5.24.0)

##### Bug Fixes

-   **eslint-plugin:** \[array-type] in fixer add missing parens for constructor types [#&#8203;4756](typescript-eslint/typescript-eslint#4756) ([#&#8203;4971](typescript-eslint/typescript-eslint#4971)) ([0377070](typescript-eslint/typescript-eslint@0377070))

##### Features

-   **eslint-plugin:** Add BigInt object type to default ban-types list ([#&#8203;4970](typescript-eslint/typescript-eslint#4970)) ([1867728](typescript-eslint/typescript-eslint@1867728))
-   **eslint-plugin:** add new 'strict' config ([#&#8203;4706](typescript-eslint/typescript-eslint#4706)) ([4a500b2](typescript-eslint/typescript-eslint@4a500b2))

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.25.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5250-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5240v5250-2022-05-17)

[Compare Source](typescript-eslint/typescript-eslint@v5.24.0...v5.25.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

### [`v5.24.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5240-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5230v5240-2022-05-16)

[Compare Source](typescript-eslint/typescript-eslint@v5.23.0...v5.24.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1357
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval recommended-rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants