Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): method-signature-style respect getter signature #4777


Copy link

@timdeschryver timdeschryver commented Apr 2, 2022

PR Checklist


Added a check to verify that the TSMethodSignature node is not a getter or setter by using the kind property.

Copy link

nx-cloud bot commented Apr 2, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bc2eb07. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Successfully ran 43 targets

Sent with 💌 from NxCloud.

Copy link

typescript-eslint bot commented Apr 2, 2022

Thanks for the PR, @timdeschryver!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

netlify bot commented Apr 2, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit bc2eb07
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #4777 (bc2eb07) into main (c59d9d7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4777   +/-   ##
  Coverage   94.28%   94.28%           
  Files         151      151           
  Lines        8208     8210    +2     
  Branches     2670     2671    +1     
+ Hits         7739     7741    +2     
  Misses        261      261           
  Partials      208      208           
Flag Coverage Δ
unittest 94.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../eslint-plugin/src/rules/method-signature-style.ts 89.15% <100.00%> (+0.26%) ⬆️

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

💯, thanks @timdeschryver!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 12dd670 into typescript-eslint:main Apr 3, 2022
18 checks passed
@timdeschryver timdeschryver deleted the fix/method-signature-style-getter branch Apr 4, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Apr 9, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
| [@typescript-eslint/eslint-plugin]( | devDependencies | minor | [`5.17.0` -> `5.18.0`]( |
| [@typescript-eslint/parser]( | devDependencies | minor | [`5.17.0` -> `5.18.0`]( |


### Release Notes

<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.18.0`](;5180-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5170v5180-2022-04-04)

[Compare Source](typescript-eslint/typescript-eslint@v5.17.0...v5.18.0)

##### Bug Fixes

-   **eslint-plugin:** method-signature-style respect getter signature ([#&#8203;4777](typescript-eslint/typescript-eslint#4777)) ([12dd670](typescript-eslint/typescript-eslint@12dd670))

##### Features

-   **eslint-plugin:** \[no-shadow] ignoreOnInitialization option ([#&#8203;4603](typescript-eslint/typescript-eslint#4603)) ([068ea9b](typescript-eslint/typescript-eslint@068ea9b))
-   **eslint-plugin:** \[no-this-alias] report on assignment expressions ([#&#8203;4718](typescript-eslint/typescript-eslint#4718)) ([8329498](typescript-eslint/typescript-eslint@8329498))


<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.18.0`](;5180-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5170v5180-2022-04-04)

[Compare Source](typescript-eslint/typescript-eslint@v5.17.0...v5.18.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](



### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.


 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.


This PR has been generated by [Renovate Bot](

Co-authored-by: cabr2-bot <>
Reviewed-by: 6543 <>
Co-authored-by: Calciumdibromid Bot <>
Co-committed-by: Calciumdibromid Bot <>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

[method-signature-style] respect getter signature
2 participants