Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): update code to use estree range instead of ts pos/end #4790

merged 2 commits into from Apr 8, 2022


Copy link

@armano2 armano2 commented Apr 6, 2022

PR Checklist


Use location data from estree instead of typescript, this change fixes fixer when used with 3th party parsers

This issue is present in any parser that modifies location data of estree nodes, eg. mdx, vue

@armano2 armano2 added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin labels Apr 6, 2022
Copy link

nx-cloud bot commented Apr 6, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9acd7e1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Successfully ran 39 targets

Sent with 💌 from NxCloud.

Copy link

typescript-eslint bot commented Apr 6, 2022

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

netlify bot commented Apr 6, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 9acd7e1
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member Author

armano2 commented Apr 6, 2022

not sure how to write proper tests for this

Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #4790 (9acd7e1) into main (c59d9d7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4790   +/-   ##
  Coverage   94.28%   94.28%           
  Files         151      151           
  Lines        8208     8210    +2     
  Branches     2670     2671    +1     
+ Hits         7739     7741    +2     
  Misses        261      261           
  Partials      208      208           
Flag Coverage Δ
unittest 94.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-plugin/src/rules/no-unnecessary-type-assertion.ts 94.66% <ø> (ø)
.../eslint-plugin/src/rules/method-signature-style.ts 89.15% <100.00%> (+0.26%) ⬆️

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Makes sense. I'll file a followup issue to add an internal lint rule to enforce this.

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) Apr 8, 2022
@JoshuaKGoldberg JoshuaKGoldberg merged commit a1e9fc4 into main Apr 8, 2022
17 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the fix/use-node-range-insteadof-typescript-4723 branch Apr 8, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Apr 13, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
| [@typescript-eslint/eslint-plugin]( | devDependencies | minor | [`5.18.0` -> `5.19.0`]( |
| [@typescript-eslint/parser]( | devDependencies | minor | [`5.18.0` -> `5.19.0`]( |


### Release Notes

<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.19.0`](;5190-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5180v5190-2022-04-11)

[Compare Source](typescript-eslint/typescript-eslint@v5.18.0...v5.19.0)

##### Bug Fixes

-   **eslint-plugin:** update code to use estree range instead of ts pos/end [#&#8203;4723](typescript-eslint/typescript-eslint#4723) ([#&#8203;4790](typescript-eslint/typescript-eslint#4790)) ([a1e9fc4](typescript-eslint/typescript-eslint@a1e9fc4))

##### Features

-   **eslint-plugin:** \[unified-signatures] add `ignoreDifferentlyNamedParameters` option ([#&#8203;4659](typescript-eslint/typescript-eslint#4659)) ([fdf95e0](typescript-eslint/typescript-eslint@fdf95e0))
-   **eslint-plugin:** add support for valid number and bigint intersections in restrict-plus-operands rule ([#&#8203;4795](typescript-eslint/typescript-eslint#4795)) ([19c600a](typescript-eslint/typescript-eslint@19c600a))


<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.19.0`](;5190-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5180v5190-2022-04-11)

[Compare Source](typescript-eslint/typescript-eslint@v5.18.0...v5.19.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](



### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.


 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.


This PR has been generated by [Renovate Bot](

Co-authored-by: cabr2-bot <>
Reviewed-by: crapStone <>
Co-authored-by: Calciumdibromid Bot <>
Co-committed-by: Calciumdibromid Bot <>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
None yet
2 participants