Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yarn audit #487

Merged
merged 4 commits into from May 2, 2019

Conversation

Projects
None yet
2 participants
@ldrick
Copy link
Contributor

commented Apr 30, 2019

Fixes #486

I ran yarn upgrade and added node-gyp to resolve for versions ^4.0.0

Show resolved Hide resolved package.json
@codecov

This comment has been minimized.

Copy link

commented May 2, 2019

Codecov Report

Merging #487 into master will decrease coverage by 1.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
- Coverage   97.14%   95.75%   -1.39%     
==========================================
  Files          77       77              
  Lines        2939     3484     +545     
  Branches      488      960     +472     
==========================================
+ Hits         2855     3336     +481     
  Misses         51       51              
- Partials       33       97      +64
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/ban-types.ts 84.21% <0%> (-15.79%) ⬇️
...ckages/eslint-plugin/src/util/getParserServices.ts 60% <0%> (-15%) ⬇️
packages/eslint-plugin/src/rules/no-unused-vars.ts 92.85% <0%> (-7.15%) ⬇️
...ckages/eslint-plugin/src/rules/prefer-interface.ts 93.75% <0%> (-6.25%) ⬇️
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 80.43% <0%> (-5.28%) ⬇️
packages/eslint-plugin/src/rules/camelcase.ts 85.71% <0%> (-5.2%) ⬇️
...-plugin/src/rules/explicit-function-return-type.ts 88.88% <0%> (-5.06%) ⬇️
...s/eslint-plugin/src/rules/interface-name-prefix.ts 83.33% <0%> (-4.17%) ⬇️
packages/eslint-plugin/src/util/types.ts 62.5% <0%> (-4.17%) ⬇️
packages/typescript-estree/src/semantic-errors.ts 87.5% <0%> (-4.17%) ⬇️
... and 51 more

@bradzacher bradzacher merged commit f029dba into typescript-eslint:master May 2, 2019

8 checks passed

Semantic Pull Request ready to be squashed
Details
codecov/patch Coverage not affected when comparing 3bf725f...c494151
Details
codecov/project 95.75% (-1.39%) compared to 3bf725f
Details
typescript-eslint.typescript-eslint Build #20190502.4 succeeded
Details
typescript-eslint.typescript-eslint (Primary code validation and tests) Primary code validation and tests succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_10_x) Run unit tests on other Node.js versions node_10_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_6_x) Run unit tests on other Node.js versions node_6_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_8_x) Run unit tests on other Node.js versions node_8_x succeeded
Details

@ldrick ldrick deleted the ldrick:486-yarn-audit branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.