Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [TS4.7] allow visiting of typeParameters in TSTypeQuery #5166

Merged
merged 2 commits into from Jun 10, 2022

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Jun 9, 2022

PR Checklist

Overview

add visiting of typeParameters in TSTypeQuery

prettier is not supporting this syntax yet

missing changes for #5067

@armano2 armano2 added bug package: eslint-plugin package: scope-manager package: visitor-keys labels Jun 9, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jun 9, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 51cabf2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Jun 9, 2022

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jun 9, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 51cabf2
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62a25f3bf5a7b40008e900d2
😎 Deploy Preview https://deploy-preview-5166--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 changed the title fix: allow visiting of typeParameters in TSTypeQuery fix: [ts 4.7] allow visiting of typeParameters in TSTypeQuery Jun 9, 2022
@armano2 armano2 changed the title fix: [ts 4.7] allow visiting of typeParameters in TSTypeQuery fix: [TS4.7] allow visiting of typeParameters in TSTypeQuery Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #5166 (51cabf2) into main (1f25daf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5166   +/-   ##
=======================================
  Coverage   93.82%   93.82%           
=======================================
  Files         286      286           
  Lines        9828     9829    +1     
  Branches     2939     2939           
=======================================
+ Hits         9221     9222    +1     
  Misses        328      328           
  Partials      279      279           
Flag Coverage Δ
unittest 93.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/scope-manager/src/referencer/TypeVisitor.ts 97.89% <100.00%> (+0.02%) ⬆️

Copy link
Member

@bradzacher bradzacher left a comment

sick_reference

@bradzacher bradzacher merged commit dc1f930 into main Jun 10, 2022
39 checks passed
@bradzacher bradzacher deleted the fix/visiting-typeParameters-in-typeQuery branch Jun 10, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this issue Jun 17, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.27.1` -> `5.28.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.27.1/5.28.0) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.27.1` -> `5.28.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.27.1/5.28.0) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.28.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5280-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5271v5280-2022-06-13)

[Compare Source](typescript-eslint/typescript-eslint@v5.27.1...v5.28.0)

##### Bug Fixes

-   \[TS4.7] allow visiting of typeParameters in TSTypeQuery ([#&#8203;5166](typescript-eslint/typescript-eslint#5166)) ([dc1f930](typescript-eslint/typescript-eslint@dc1f930))
-   **eslint-plugin:** \[space-infix-ops] support for optional property without type ([#&#8203;5155](typescript-eslint/typescript-eslint#5155)) ([1f25daf](typescript-eslint/typescript-eslint@1f25daf))

##### Features

-   **eslint-plugin:** \[consistent-generic-constructors] add rule ([#&#8203;4924](typescript-eslint/typescript-eslint#4924)) ([921cdf1](typescript-eslint/typescript-eslint@921cdf1))

#### [5.27.1](typescript-eslint/typescript-eslint@v5.27.0...v5.27.1) (2022-06-06)

##### Bug Fixes

-   **eslint-plugin:** \[space-infix-ops] correct PropertyDefinition with typeAnnotation ([#&#8203;5113](typescript-eslint/typescript-eslint#5113)) ([d320174](typescript-eslint/typescript-eslint@d320174))
-   **eslint-plugin:** \[space-infix-ops] regression fix for conditional types ([#&#8203;5135](typescript-eslint/typescript-eslint#5135)) ([e5238c8](typescript-eslint/typescript-eslint@e5238c8))
-   **eslint-plugin:** \[space-infix-ops] regression fix for type aliases ([#&#8203;5138](typescript-eslint/typescript-eslint#5138)) ([4e13deb](typescript-eslint/typescript-eslint@4e13deb))

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.28.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5280-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5271v5280-2022-06-13)

[Compare Source](typescript-eslint/typescript-eslint@v5.27.1...v5.28.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

#### [5.27.1](typescript-eslint/typescript-eslint@v5.27.0...v5.27.1) (2022-06-06)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1409
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug package: eslint-plugin package: scope-manager package: visitor-keys
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants