Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-base-to-string] add missing apostrophe to message #5270

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Jun 28, 2022

PR Checklist

Overview

It's been like this for years. Oops.

@nx-cloud
Copy link

nx-cloud bot commented Jun 28, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 32ca080. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Jun 28, 2022

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jun 28, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 32ca080
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62bb4b8002e18e000880e803
😎 Deploy Preview https://deploy-preview-5270--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #5270 (32ca080) into main (fc48258) will increase coverage by 2.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5270      +/-   ##
==========================================
+ Coverage   91.67%   93.76%   +2.09%     
==========================================
  Files         363      287      -76     
  Lines       12227     9871    -2356     
  Branches     3549     2954     -595     
==========================================
- Hits        11209     9256    -1953     
+ Misses        668      335     -333     
+ Partials      350      280      -70     
Flag Coverage Δ
unittest 93.76% <ø> (+2.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/no-base-to-string.ts 98.41% <ø> (ø)
packages/type-utils/src/typeFlagUtils.ts
packages/type-utils/src/getContextualType.ts
packages/utils/src/eslint-utils/applyDefault.ts
packages/utils/src/ts-eslint-scope/Definition.ts
packages/type-utils/src/isUnsafeAssignment.ts
...t-estree/src/create-program/useProvidedPrograms.ts
...estree/src/create-program/createIsolatedProgram.ts
packages/utils/src/eslint-utils/RuleTester.ts
packages/typescript-estree/src/simple-traverse.ts
... and 67 more

@bradzacher bradzacher added the bug label Jun 29, 2022
@bradzacher bradzacher merged commit 58034e3 into typescript-eslint:main Jun 29, 2022
39 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-base-to-string-message-missing-apostrophe branch Jun 29, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this issue Jul 11, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | patch | [`5.30.0` -> `5.30.5`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.30.0/5.30.5) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | patch | [`5.30.0` -> `5.30.5`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.30.0/5.30.5) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.30.5`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5305-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5304v5305-2022-07-04)

[Compare Source](typescript-eslint/typescript-eslint@v5.30.4...v5.30.5)

##### Bug Fixes

-   **eslint-plugin:** \[consistent-indexed-object-style] fix record mode fixer for generics with a default value ([#&#8203;5280](typescript-eslint/typescript-eslint#5280)) ([57f032c](typescript-eslint/typescript-eslint@57f032c))

### [`v5.30.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5304-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5303v5304-2022-07-03)

[Compare Source](typescript-eslint/typescript-eslint@v5.30.3...v5.30.4)

**Note:** Version bump only for package [@&#8203;typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)

### [`v5.30.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5303-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5302v5303-2022-07-01)

[Compare Source](typescript-eslint/typescript-eslint@v5.30.2...v5.30.3)

**Note:** Version bump only for package [@&#8203;typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)

### [`v5.30.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5302-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5301v5302-2022-07-01)

[Compare Source](typescript-eslint/typescript-eslint@v5.30.1...v5.30.2)

**Note:** Version bump only for package [@&#8203;typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)

### [`v5.30.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5301-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5300v5301-2022-07-01)

[Compare Source](typescript-eslint/typescript-eslint@v5.30.0...v5.30.1)

##### Bug Fixes

-   **eslint-plugin:** \[no-base-to-string] add missing apostrophe to message ([#&#8203;5270](typescript-eslint/typescript-eslint#5270)) ([d320174](typescript-eslint/typescript-eslint@58034e3))

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.30.5`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5305-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5304v5305-2022-07-04)

[Compare Source](typescript-eslint/typescript-eslint@v5.30.4...v5.30.5)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

### [`v5.30.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5304-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5303v5304-2022-07-03)

[Compare Source](typescript-eslint/typescript-eslint@v5.30.3...v5.30.4)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

### [`v5.30.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5303-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5302v5303-2022-07-01)

[Compare Source](typescript-eslint/typescript-eslint@v5.30.2...v5.30.3)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

### [`v5.30.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5302-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5301v5302-2022-07-01)

[Compare Source](typescript-eslint/typescript-eslint@v5.30.1...v5.30.2)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

### [`v5.30.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5301-2022-07-01)

[Compare Source](typescript-eslint/typescript-eslint@v5.30.0...v5.30.1)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1443
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants