Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert 508bb41 #534

Merged
merged 1 commit into from May 16, 2019

Conversation

Projects
None yet
2 participants
@bradzacher
Copy link
Member

commented May 16, 2019

Reverts #530
508bb41

Accidentally merged this PR early.

@codecov

This comment has been minimized.

Copy link

commented May 16, 2019

Codecov Report

Merging #534 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files         104      104           
  Lines        4235     4235           
  Branches     1153     1153           
=======================================
  Hits         3990     3990           
  Misses        143      143           
  Partials      102      102
Impacted Files Coverage Δ
...ackages/experimental-utils/src/ts-eslint/Linter.ts 0% <ø> (ø) ⬆️
packages/typescript-estree/src/semantic-errors.ts 87.5% <ø> (ø) ⬆️
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts 93.33% <ø> (ø) ⬆️
...ages/experimental-utils/src/ts-eslint/CLIEngine.ts 0% <ø> (ø) ⬆️
...ges/experimental-utils/src/ts-eslint/SourceCode.ts 0% <ø> (ø) ⬆️
packages/typescript-estree/src/ast-converter.ts 100% <100%> (ø) ⬆️
...ages/eslint-plugin/src/rules/prefer-regexp-exec.ts 100% <100%> (ø) ⬆️
packages/typescript-estree/src/parser.ts 95% <100%> (ø) ⬆️

@bradzacher bradzacher merged commit c480eab into master May 16, 2019

8 checks passed

Semantic Pull Request ready to be squashed
Details
codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 94.21% (+0%) compared to 508bb41
Details
typescript-eslint.typescript-eslint Build #20190516.10 succeeded
Details
typescript-eslint.typescript-eslint (Primary code validation and tests) Primary code validation and tests succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_10_x) Run unit tests on other Node.js versions node_10_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_6_x) Run unit tests on other Node.js versions node_6_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_8_x) Run unit tests on other Node.js versions node_8_x succeeded
Details

@bradzacher bradzacher deleted the revert-530-tighter-linting branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.