Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [member-ordering] support static blocks #5417

Merged

Conversation

Josh-Cena
Copy link
Contributor

@Josh-Cena Josh-Cena commented Aug 4, 2022

PR Checklist

Overview

@nx-cloud
Copy link

nx-cloud bot commented Aug 4, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 23ebca9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Aug 4, 2022

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 23ebca9
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62eecd94ee93ef00082f27e4
😎 Deploy Preview https://deploy-preview-5417--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Looks great, thanks for sending this in so quickly!

Just requesting changes on a bit more test coverage.

packages/eslint-plugin/docs/rules/member-ordering.md Outdated Show resolved Hide resolved
class Foo {
m() {}
f = 1;
static {}
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg Aug 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add test cases for static {} being intermixed with other blocks? Just to make sure there are no funky edge cases in ordering behavior.

Copy link
Contributor Author

@Josh-Cena Josh-Cena Aug 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By continuity principle (something I just made up) the tests should be sufficient. Let me know if there are specific quirks worth testing that you have in mind.

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Aug 5, 2022
Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
@Josh-Cena Josh-Cena requested a review from JoshuaKGoldberg Aug 6, 2022
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Perfect 😄 thanks!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) Aug 6, 2022
@JoshuaKGoldberg JoshuaKGoldberg merged commit 5983e5a into typescript-eslint:main Aug 6, 2022
38 checks passed
@Josh-Cena Josh-Cena deleted the static-block-order branch Aug 7, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Aug 9, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.32.0` -> `5.33.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.32.0/5.33.0) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.32.0` -> `5.33.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.32.0/5.33.0) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.33.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5330-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5320v5330-2022-08-08)

[Compare Source](typescript-eslint/typescript-eslint@v5.32.0...v5.33.0)

##### Bug Fixes

-   **eslint-plugin:** \[no-extra-parens] handle await with type assertion ([#&#8203;5428](typescript-eslint/typescript-eslint#5428)) ([e03826f](typescript-eslint/typescript-eslint@e03826f))
-   **website:** add explicit frontmatter description to rule docs ([#&#8203;5429](typescript-eslint/typescript-eslint#5429)) ([63cba5f](typescript-eslint/typescript-eslint@63cba5f))

##### Features

-   **eslint-plugin:** \[member-ordering] support static blocks ([#&#8203;5417](typescript-eslint/typescript-eslint#5417)) ([5983e5a](typescript-eslint/typescript-eslint@5983e5a))
-   **eslint-plugin:** \[prefer-as-const] adds support for class properties ([#&#8203;5413](typescript-eslint/typescript-eslint#5413)) ([d2394f8](typescript-eslint/typescript-eslint@d2394f8))

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.33.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5330-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5320v5330-2022-08-08)

[Compare Source](typescript-eslint/typescript-eslint@v5.32.0...v5.33.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTEuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE1MS4yIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1494
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [member ordering] Static initialization blocks are regarded as public instance methods.
2 participants