Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-extra-parens] handle await with type assertion #5428

Merged
merged 3 commits into from Aug 7, 2022

Conversation

yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented Aug 6, 2022

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Aug 6, 2022

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Aug 6, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ab6fad3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Aug 6, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ab6fad3
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62efc78aa29f140008af91be
😎 Deploy Preview https://deploy-preview-5428--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #5428 (dc3656d) into main (df4e05e) will increase coverage by 2.46%.
The diff coverage is 100.00%.

Current head dc3656d differs from pull request most recent head ab6fad3. Consider uploading reports for the commit ab6fad3 to get more accurate results

@@            Coverage Diff             @@
##             main    #5428      +/-   ##
==========================================
+ Coverage   91.36%   93.83%   +2.46%     
==========================================
  Files         132      290     +158     
  Lines        1494     9988    +8494     
  Branches      226     3006    +2780     
==========================================
+ Hits         1365     9372    +8007     
- Misses         65      335     +270     
- Partials       64      281     +217     
Flag Coverage Δ
unittest 93.83% <100.00%> (+2.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-extra-parens.ts 90.78% <100.00%> (ø)
...ages/eslint-plugin/src/rules/default-param-last.ts 100.00% <0.00%> (ø)
...-plugin/src/rules/explicit-function-return-type.ts 100.00% <0.00%> (ø)
.../eslint-plugin/src/rules/no-useless-constructor.ts 95.23% <0.00%> (ø)
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 95.00% <0.00%> (ø)
packages/eslint-plugin/src/configs/base.ts 100.00% <0.00%> (ø)
...ckages/eslint-plugin/src/util/getESLintCoreRule.ts 75.00% <0.00%> (ø)
...plugin/src/rules/naming-convention-utils/shared.ts 100.00% <0.00%> (ø)
...t-plugin/src/rules/class-literal-property-style.ts 100.00% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/no-var-requires.ts 90.00% <0.00%> (ø)
... and 149 more

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Code change seems reasonable, thanks for sending it in! A couple of nits, but mostly requesting changes on filling in the missing test coverage.

packages/eslint-plugin/src/rules/no-extra-parens.ts Outdated Show resolved Hide resolved
packages/eslint-plugin/src/rules/no-extra-parens.ts Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Aug 6, 2022
@yeonjuan yeonjuan requested a review from JoshuaKGoldberg Aug 7, 2022
@yeonjuan
Copy link
Contributor Author

yeonjuan commented Aug 7, 2022

@JoshuaKGoldberg Thanks for the review 👍

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Super, thanks!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) Aug 7, 2022
@JoshuaKGoldberg JoshuaKGoldberg merged commit e03826f into typescript-eslint:main Aug 7, 2022
34 of 35 checks passed
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Aug 9, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.32.0` -> `5.33.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.32.0/5.33.0) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.32.0` -> `5.33.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.32.0/5.33.0) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.33.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5330-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5320v5330-2022-08-08)

[Compare Source](typescript-eslint/typescript-eslint@v5.32.0...v5.33.0)

##### Bug Fixes

-   **eslint-plugin:** \[no-extra-parens] handle await with type assertion ([#&#8203;5428](typescript-eslint/typescript-eslint#5428)) ([e03826f](typescript-eslint/typescript-eslint@e03826f))
-   **website:** add explicit frontmatter description to rule docs ([#&#8203;5429](typescript-eslint/typescript-eslint#5429)) ([63cba5f](typescript-eslint/typescript-eslint@63cba5f))

##### Features

-   **eslint-plugin:** \[member-ordering] support static blocks ([#&#8203;5417](typescript-eslint/typescript-eslint#5417)) ([5983e5a](typescript-eslint/typescript-eslint@5983e5a))
-   **eslint-plugin:** \[prefer-as-const] adds support for class properties ([#&#8203;5413](typescript-eslint/typescript-eslint#5413)) ([d2394f8](typescript-eslint/typescript-eslint@d2394f8))

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.33.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5330-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5320v5330-2022-08-08)

[Compare Source](typescript-eslint/typescript-eslint@v5.32.0...v5.33.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTEuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE1MS4yIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1494
Reviewed-by: 6543 <6543@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [no-extra-parens] incorrect precedence for await vs assertion
2 participants