Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [member-ordering] support private fields #5859

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

sviat9440
Copy link
Contributor

PR Checklist

@nx-cloud
Copy link

nx-cloud bot commented Oct 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4576c26. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sviat9440!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Oct 23, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4576c26
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/637efbb1be4a2c000806ef5a
😎 Deploy Preview https://deploy-preview-5859--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Merging #5859 (4576c26) into main (53671d3) will increase coverage by 0.00%.
The diff coverage is 95.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5859   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files         366      366           
  Lines       12353    12365   +12     
  Branches     3611     3616    +5     
=======================================
+ Hits        11276    11287   +11     
  Misses        768      768           
- Partials      309      310    +1     
Flag Coverage Δ
unittest 91.28% <95.83%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/member-ordering.ts 95.39% <95.83%> (-0.32%) ⬇️

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Not a full review, just a quick glance

packages/eslint-plugin/src/rules/member-ordering.ts Outdated Show resolved Hide resolved
@bradzacher bradzacher changed the title fix(eslint-plugin): Support private fields (#4182) fix(eslint-plugin): [member-ordering] support private fields Oct 23, 2022
@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Oct 23, 2022
@sviat9440 sviat9440 marked this pull request as draft October 24, 2022 07:46
@sviat9440
Copy link
Contributor Author

@bradzacher

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Nov 18, 2022
@sviat9440
Copy link
Contributor Author

@JoshuaKGoldberg the response to what do you expect?

@JoshuaKGoldberg
Copy link
Member

There's an open thread 🙂 #5859 (comment)

@JoshuaKGoldberg JoshuaKGoldberg removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 23, 2022
bradzacher
bradzacher previously approved these changes Nov 23, 2022
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking good to me!
thanks for adding this!

}
// Only class instance fields, methods, get and set can have decorators attached to them
if (
accessibility !== '#private' &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL you can't add decorators to #private members.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can create an issue to support decorators from TypeScript 5.

@bradzacher
Copy link
Member

If you resolve the merge conflict then we can get this in!

@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party 1 approval One team member has approved this PR; a second should be enough to merge it labels Nov 23, 2022
@sviat9440
Copy link
Contributor Author

resolved

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 25, 2022
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im_gonna_ship_it

@bradzacher bradzacher merged commit f02761a into typescript-eslint:main Nov 25, 2022
JoshuaKGoldberg pushed a commit to JoshuaKGoldberg/typescript-eslint that referenced this pull request Nov 25, 2022
…ipt-eslint#5859)

Co-authored-by: Святослав Зайцев <sz@agentapp.ru>
YusukeHirao pushed a commit to YusukeHirao/markuplint that referenced this pull request Dec 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval One team member has approved this PR; a second should be enough to merge it enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[member-ordering] support private fields
3 participants