-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [member-ordering] support private fields #5859
Conversation
Thanks for the PR, @sviat9440! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5859 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 366 366
Lines 12353 12365 +12
Branches 3611 3616 +5
=======================================
+ Hits 11276 11287 +11
Misses 768 768
- Partials 309 310 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Not a full review, just a quick glance
@JoshuaKGoldberg the response to what do you expect? |
There's an open thread 🙂 #5859 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking good to me!
thanks for adding this!
} | ||
// Only class instance fields, methods, get and set can have decorators attached to them | ||
if ( | ||
accessibility !== '#private' && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL you can't add decorators to #private
members.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can create an issue to support decorators from TypeScript 5.
If you resolve the merge conflict then we can get this in! |
resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ipt-eslint#5859) Co-authored-by: Святослав Зайцев <sz@agentapp.ru>
PR Checklist