-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [no-floating-promises] add suggestion fixer to add an 'await' #5943
Conversation
Thanks for the PR, @sena-anny! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5943 +/- ##
==========================================
+ Coverage 91.27% 91.28% +0.01%
==========================================
Files 366 366
Lines 12433 12445 +12
Branches 3641 3645 +4
==========================================
+ Hits 11348 11361 +13
+ Misses 774 773 -1
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good start, thanks for sending this in @sena-anny! 🙌
Requesting changes on a bit more test coverage, and reducing the area replaced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So close! 🙌
Will defer to bradzacher's review :)
@bradzacher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the precedence fixes, this LGTM!
Thanks for adding a fixer!
PR Checklist
Overview
Add suggestion fixer to add an 'await'