feat(eslint-plugin): [member-ordering] add a required option for required vs. optional member ordering #5965
…which ensures that all required members appear before all optional members.
…redMember to be slightly faster and adding jsdoc comments for it and isMemberOptional.
Thanks for the PR, @asdf93074!
typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.
The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.
🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings.
Additional details and impacted files
@@ Coverage Diff @@ ## main #5965 +/- ## ========================================== + Coverage 91.24% 91.27% +0.02% ========================================== Files 366 366 Lines 12380 12417 +37 Branches 3621 3631 +10 ========================================== + Hits 11296 11333 +37 Misses 774 774 Partials 310 310
Flags with carried forward coverage won't be shown. Click here to find out more.
…d which takes first or last as a value and adding functionality to check order based on both of these along with additional tests.
…and removing unused code.
I'll leave this open for a bit in case another maintainer wants to poke at it or suggest an alternative API name (which we can apply ourselves if you don't want to keep receiving extra work because of our indecision 😅). But I've set a reminder to merge it this weekend if nobody requests changes, so it'll be available in our next stable version.
Edit: see #5965 (comment), will go on Monday!