Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support for ESLint v6 #5972

merged 1 commit into from Nov 14, 2022


Copy link

@bmish bmish commented Nov 11, 2022

Drops support for ESLint v6.

Fixes #5968.

Breaking change targeting v6 (#5886).

Also changed the ESLint v6 integration test to test ESLint v7 instead.

Copy link

Thanks for the PR, @bmish!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on

Copy link

nx-cloud bot commented Nov 11, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d7ac298. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@@ -49,7 +49,7 @@
"typescript": "*"
"peerDependencies": {
"eslint": "*"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we might as well include the constraint here too.

@bmish bmish force-pushed the drop-eslint-6 branch 3 times, most recently from 4e169a3 to e67e362 Compare November 12, 2022 16:15
drop support for ESLint v6
Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 20f49b7 into typescript-eslint:v6 Nov 14, 2022
35 checks passed
@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: drop support for ESLint v6 chore: drop support for ESLint v6 Nov 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants