Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [adjacent-overload-signatures] check BlockStatement nodes #5998

Merged
merged 3 commits into from Nov 17, 2022

Conversation

lsdsjy
Copy link
Contributor

@lsdsjy lsdsjy commented Nov 16, 2022

PR Checklist

Overview

Overloaded function declarations can also appear in BlockStatements and should be checked.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @lsdsjy!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Nov 16, 2022

Nx Cloud Report

CI is running for commit 5b25f2a.

📂 Click to track the progress, see the status, the terminal output, and the build insights.


Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Nov 16, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5b25f2a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63766b51d176ea00093b962b
😎 Deploy Preview https://deploy-preview-5998--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this in @lsdsjy! Per our Contributing guide we normally ask that PRs address a previously-opened issue, to help us triage requests & make sure they're valid before sending.

In this case I think it's fine to not because the bug is pretty clear. So just for next time please 😄

Requesting changes on what I mentioned inline.

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Nov 16, 2022
@bradzacher bradzacher changed the title fix(eslint-plugin): [adjacent-overload-signatures] check BlockStatement nodes feat(eslint-plugin): [adjacent-overload-signatures] check BlockStatement nodes Nov 16, 2022
@bradzacher bradzacher added the enhancement New feature or request label Nov 16, 2022
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this @lsdsjy! 🙌

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) November 17, 2022 17:11
@JoshuaKGoldberg JoshuaKGoldberg merged commit 97d3e56 into typescript-eslint:main Nov 17, 2022
34 of 37 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting response Issues waiting for a reply from the OP or another party enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants