Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scope-manager): add support for TS4.9 satisfies expression #6059

merged 1 commit into from Nov 22, 2022


Copy link

@bradzacher bradzacher commented Nov 22, 2022

PR Checklist


Stack created with Sapling. Best reviewed with ReviewStack.

feat(scope-manager): add support for TS4.9 satisfies expression

Copy link

nx-cloud bot commented Nov 22, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 128d2ba. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

Copy link

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on

Copy link

netlify bot commented Nov 22, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 128d2ba
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #6059 (128d2ba) into main (01159d2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6059   +/-   ##
  Coverage   91.28%   91.28%           
  Files         366      366           
  Lines       12352    12353    +1     
  Branches     3612     3612           
+ Hits        11275    11276    +1     
  Misses        768      768           
  Partials      309      309           
Flag Coverage Δ
unittest 91.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/scope-manager/src/referencer/Referencer.ts 95.98% <100.00%> (+0.01%) ⬆️

@bradzacher bradzacher changed the title feat(scope-manager): add support for TS4.9 satisfies expression fix(scope-manager): add support for TS4.9 satisfies expression Nov 22, 2022
@bradzacher bradzacher added the bug Something isn't working label Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

Bug: [@typescript-eslint/no-unused-vars] not collect used types on satisfies operator
2 participants