feat: remove partial type-information program #6066
Thanks for the PR, @bradzacher!
typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.
The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.
🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.
Additional details and impacted files
@@ Coverage Diff @@ ## v6 #6066 +/- ## ========================================== - Coverage 91.66% 91.64% -0.02% ========================================== Files 354 354 Lines 12199 12200 +1 Branches 3581 3582 +1 ========================================== - Hits 11182 11181 -1 - Misses 721 722 +1 - Partials 296 297 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
For reference I just did a really quick perf test of the before-and-after for this.
$ TSESTREE_SINGLE_RUN=true node --cpu-prof ./node_modules/.bin/eslint --no-eslintrc --parser="@typescript-eslint/parser" --ext=".ts,.tsx" .
Loading the profiles into https://www.speedscope.app/ I can see that
It doesn't seem like much, but our codebase is relatively small - ~2.6k files for ~207k SLOC in total. For a larger code base I'd expect more of an impact, though it'll likely still be pretty small overall.
For reference the CPU profiles: PROFILES.zip