Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-shadow] add call and method signatures to ignoreFunctionTypeParameterNameValueShadow #6129

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Nov 29, 2022

PR Checklist

Overview

Adds call signatures and method signatures to the node types that no-shadow will ignore when ignoreFunctionTypeParameterNameValueShadow is true.

I embarrassingly got this rule's logic wrong the first time I tried triaging the issues, so asking for more oversight here. 馃ゲ

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


馃檹 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Nov 29, 2022

鈽侊笍 Nx Cloud Report

CI is running/has finished running commands for commit 4dba7d7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

馃搨 See all runs for this branch


鉁 Successfully ran 47 targets

Sent with 馃拰 from NxCloud.

@netlify
Copy link

netlify bot commented Nov 29, 2022

Deploy Preview for typescript-eslint ready!

Name Link
馃敤 Latest commit 4dba7d7
馃攳 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/638661fae26f2f000835a43e
馃槑 Deploy Preview https://deploy-preview-6129--typescript-eslint.netlify.app
馃摫 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(no-shadow): add call and method signatures to ignoreFunctionTypeParameterNameValueShadow fix(eslint-plugin) [no-shadow] add call and method signatures to ignoreFunctionTypeParameterNameValueShadow Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #6129 (4dba7d7) into main (2abadc6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6129   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         366      366           
  Lines       12417    12420    +3     
  Branches     3631     3632    +1     
=======================================
+ Hits        11333    11336    +3     
  Misses        774      774           
  Partials      310      310           
Flag Coverage 螖
unittest 91.27% <100.00%> (+<0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
packages/eslint-plugin/src/rules/no-shadow.ts 77.65% <100.00%> (+0.12%) 猬嗭笍
...s/eslint-plugin/src/rules/prefer-optional-chain.ts 98.63% <0.00%> (+0.01%) 猬嗭笍

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(eslint-plugin) [no-shadow] add call and method signatures to ignoreFunctionTypeParameterNameValueShadow fix(eslint-plugin): [no-shadow] add call and method signatures to ignoreFunctionTypeParameterNameValueShadow Nov 29, 2022
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review November 29, 2022 20:07
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ramsay_good_code

@bradzacher bradzacher changed the title fix(eslint-plugin): [no-shadow] add call and method signatures to ignoreFunctionTypeParameterNameValueShadow fix(eslint-plugin): [no-shadow] add call and method signatures to ignoreFunctionTypeParameterNameValueShadow Dec 2, 2022
@bradzacher bradzacher merged commit 9d58b6b into typescript-eslint:main Dec 2, 2022
40 of 44 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-shadow-more-function-def-types branch December 2, 2022 01:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [no-shadow] ignoreFunctionTypeParameterNameValueShadow = true false positive on function interface dec
2 participants