Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): remove the jsx option requirement for automatic jsx pragma resolution #6134

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

Solo-steven
Copy link
Contributor

fix #5153.

PR Checklist

Overview

@nx-cloud
Copy link

nx-cloud bot commented Nov 30, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 27c3763. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Solo-steven!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Nov 30, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 27c3763
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/638748397189fe0009fb8bcc
😎 Deploy Preview https://deploy-preview-6134--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whatugot

@bradzacher bradzacher changed the title fix(parser): remove the jsx option requirement for auto pragma resolu… fix(parser): remove the jsx option requirement for automatic jsx pragma resolution Dec 2, 2022
@bradzacher bradzacher merged commit e777f5e into typescript-eslint:main Dec 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: 5.27.0 regression: @typescript-eslint/no-unused-vars wrongly reports the jsxFactory set in tsconfig.json
2 participants