Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [member-ordering] correctly invert optionalityOrder #6256

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

I'd flipped the order of the rule option when taking over the PR. 馃う

@nx-cloud
Copy link

nx-cloud bot commented Dec 20, 2022

鈽侊笍 Nx Cloud Report

CI is running/has finished running commands for commit 99587a6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

馃搨 See all runs for this branch


Successfully ran 47 targets

Sent with 馃拰 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


馃檹 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Dec 20, 2022

Deploy Preview for typescript-eslint ready!

Name Link
馃敤 Latest commit 99587a6
馃攳 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63a2141f15fa3f000808fea1
馃槑 Deploy Preview https://deploy-preview-6256--typescript-eslint.netlify.app
馃摫 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #6256 (99587a6) into main (bc63c92) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6256   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files         366      366           
  Lines       12445    12445           
  Branches     3645     3645           
=======================================
  Hits        11361    11361           
  Misses        773      773           
  Partials      311      311           
Flag Coverage 螖
unittest 91.28% <100.00%> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...ackages/eslint-plugin/src/rules/member-ordering.ts 96.13% <100.00%> (酶)

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dd0.png

@JoshuaKGoldberg
Copy link
Member Author

Yeah 馃槥

@JoshuaKGoldberg JoshuaKGoldberg merged commit ccd45d4 into typescript-eslint:main Dec 20, 2022
41 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the fix-member-ordering-optionality-order branch December 20, 2022 22:16
omril1 pushed a commit to omril1/typescript-eslint that referenced this pull request Dec 22, 2022
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Dec 27, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | patch | [`5.47.0` -> `5.47.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.47.0/5.47.1) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | patch | [`5.47.0` -> `5.47.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.47.0/5.47.1) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.47.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5471-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5470v5471-2022-12-26)

[Compare Source](typescript-eslint/typescript-eslint@v5.47.0...v5.47.1)

##### Bug Fixes

-   **ast-spec:** correct some incorrect ast types ([#&#8203;6257](typescript-eslint/typescript-eslint#6257)) ([0f3f645](typescript-eslint/typescript-eslint@0f3f645))
-   **eslint-plugin:** \[member-ordering] correctly invert optionalityOrder ([#&#8203;6256](typescript-eslint/typescript-eslint#6256)) ([ccd45d4](typescript-eslint/typescript-eslint@ccd45d4))

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.47.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5471-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5470v5471-2022-12-26)

[Compare Source](typescript-eslint/typescript-eslint@v5.47.0...v5.47.1)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

</details>

---

### Configuration

馃搮 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

馃殾 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

馃敃 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43My4xIiwidXBkYXRlZEluVmVyIjoiMzQuNzMuMSJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1693
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [member-ordering] optionalityOrder is reversed
2 participants