Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typescript-estree): remove unnecessary this.inTypeMode field #6375

merged 1 commit into from Jan 25, 2023


Copy link

PR Checklist


I missed this when I did #5915 - this piece of converter state is now completely unnecessary because #5915 cleaned up the last reference to it.

This PR just deletes the now unused code.

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Jan 25, 2023
Copy link

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on

Copy link

nx-cloud bot commented Jan 25, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1dba0d6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #6375 (1dba0d6) into v6 (c8c0a14) will decrease coverage by 0.01%.
The diff coverage is 91.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #6375      +/-   ##
- Coverage   91.63%   91.62%   -0.01%     
  Files         354      354              
  Lines       12202    12196       -6     
  Branches     3583     3582       -1     
- Hits        11181    11175       -6     
  Misses        721      721              
  Partials      300      300              
Flag Coverage Δ
unittest 91.62% <91.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 97.19% <91.66%> (-0.03%) ⬇️

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@bradzacher bradzacher merged commit 4528b8d into v6 Jan 25, 2023
36 checks passed
@bradzacher bradzacher deleted the v6-cleanup-convert-inTypeMode branch January 25, 2023 03:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
repo maintenance things to do with maintenance of the repo, and not with code/docs
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants