Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): throw errors on interface with implements #6551

merged 7 commits into from Mar 8, 2023


Copy link

@fisker fisker commented Mar 1, 2023

PR Checklist


implements on TSInterfaceDeclaration was removed in #4863, but not throwing an error.

Copy link

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on

Copy link

nx-cloud bot commented Mar 1, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c2e8575. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 51 targets

Sent with 💌 from NxCloud.

Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c2e8575
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #6551 (c2e8575) into v6 (c562e18) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #6551      +/-   ##
- Coverage   87.58%   87.55%   -0.03%     
  Files         365      365              
  Lines       12500    12504       +4     
  Branches     3686     3688       +2     
  Hits        10948    10948              
- Misses       1190     1194       +4     
  Partials      362      362              
Flag Coverage Δ
unittest 87.55% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 31.46% <0.00%> (-0.19%) ⬇️

@bradzacher bradzacher added this to the 6.0.0 milestone Mar 6, 2023
Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

packages/typescript-estree/src/convert.ts Outdated Show resolved Hide resolved
Copy link

@fisker - I think that this will need a merge back from v6 and update the snapshot because of your #6556 change.

Copy link
Contributor Author

fisker commented Mar 6, 2023

Not near a laptop, I can do it tomorrow.

@bradzacher bradzacher merged commit 67e05c8 into typescript-eslint:v6 Mar 8, 2023
41 of 43 checks passed
@fisker fisker deleted the interface-implements branch March 8, 2023 23:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants