Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve error location #6556

merged 12 commits into from Mar 6, 2023


Copy link

@fisker fisker commented Mar 2, 2023

PR Checklist


Copy link

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on

Copy link

nx-cloud bot commented Mar 2, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fb9e9fe. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 51 targets

Sent with 💌 from NxCloud.

Copy link

netlify bot commented Mar 2, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fb9e9fe
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fisker fisker marked this pull request as ready for review March 2, 2023 06:27
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #6556 (fb9e9fe) into v6 (a3b177d) will decrease coverage by 0.14%.
The diff coverage is 26.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #6556      +/-   ##
- Coverage   87.72%   87.58%   -0.14%     
  Files         365      365              
  Lines       12479    12500      +21     
  Branches     3679     3686       +7     
+ Hits        10947    10948       +1     
- Misses       1170     1190      +20     
  Partials      362      362              
Flag Coverage Δ
unittest 87.58% <26.53%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 31.64% <16.66%> (-0.66%) ⬇️
packages/typescript-estree/src/node-utils.ts 63.31% <53.84%> (-1.79%) ⬇️

@bradzacher bradzacher added this to the 6.0.0 milestone Mar 6, 2023
@bradzacher bradzacher merged commit 355adf0 into typescript-eslint:v6 Mar 6, 2023
41 of 43 checks passed
@fisker fisker deleted the ts-error branch March 6, 2023 13:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants