Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): fix error handling on ImportExpression #6587

merged 5 commits into from Mar 13, 2023


Copy link

@fisker fisker commented Mar 9, 2023

PR Checklist


When parsing import(), there is no node.arguments[0].getStart to call.

CI log

Copy link

nx-cloud bot commented Mar 9, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 008065a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 50 targets

Sent with 💌 from NxCloud.

Copy link

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on

Copy link

netlify bot commented Mar 9, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 008065a
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #6587 (008065a) into v6 (530185b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #6587      +/-   ##
- Coverage   87.49%   87.49%   -0.01%     
  Files         365      365              
  Lines       12511    12512       +1     
  Branches     3694     3695       +1     
  Hits        10947    10947              
- Misses       1202     1203       +1     
  Partials      362      362              
Flag Coverage Δ
unittest 87.49% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 30.96% <0.00%> (-0.05%) ⬇️

@bradzacher bradzacher added this to the 6.0.0 milestone Mar 11, 2023
Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@bradzacher bradzacher changed the title fix: fix error handling on ImportExpression fix(typescript-estree): fix error handling on ImportExpression Mar 13, 2023
@bradzacher bradzacher merged commit e8cdd5c into typescript-eslint:v6 Mar 13, 2023
43 of 45 checks passed
@fisker fisker deleted the import-expression-error branch March 13, 2023 01:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants