Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove moduleResolver API #6609

merged 1 commit into from Mar 13, 2023


Copy link

Removes parserOptions.moduleResolver.

PR Checklist


As we discussed in the thread - we're removing this API.
We don't have any evidence that it's widely used and there is a pretty significant maintenance burden to keep it.

@bradzacher bradzacher added this to the 6.0.0 milestone Mar 13, 2023
Copy link

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on

Copy link

nx-cloud bot commented Mar 13, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1869990. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 51 targets

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the breaking change This change will require a new major version to be released label Mar 13, 2023
Copy link

netlify bot commented Mar 13, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1869990
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #6609 (1869990) into v6 (e8cdd5c) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #6609      +/-   ##
- Coverage   87.47%   87.40%   -0.07%     
  Files         365      365              
  Lines       12519    12508      -11     
  Branches     3697     3694       -3     
- Hits        10951    10933      -18     
- Misses       1205     1213       +8     
+ Partials      363      362       -1     
Flag Coverage Δ
unittest 87.40% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/create-program/getWatchProgramsForProjects.ts 84.83% <ø> (-0.17%) ⬇️
...ges/typescript-estree/src/create-program/shared.ts 77.50% <ø> (-2.94%) ⬇️ 87.50% <ø> (-2.30%) ⬇️
...-estree/src/create-program/createDefaultProgram.ts 76.19% <100.00%> (-2.08%) ⬇️

... and 2 files with indirect coverage changes

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪 🔪 🔪

@JoshuaKGoldberg JoshuaKGoldberg merged commit f0f45a9 into v6 Mar 13, 2023
42 of 43 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the v6-drop-module-resolver-api branch March 13, 2023 04:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
breaking change This change will require a new major version to be released
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants