Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): throw errors when abstract property has initializer #6613

Merged
merged 12 commits into from Mar 17, 2023

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Mar 13, 2023

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Mar 13, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f95b84c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
Node 14 - nx test eslint-plugin --coverage=false
✅ Successfully ran 49 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Mar 13, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3d509cf
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64125cff7757750008e4f65c
😎 Deploy Preview https://deploy-preview-6613--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fisker fisker marked this pull request as ready for review March 13, 2023 06:26
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 love to see it, thanks as always!

packages/typescript-estree/src/convert.ts Outdated Show resolved Hide resolved
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
@bradzacher bradzacher added this to the 6.0.0 milestone Mar 13, 2023
@bradzacher
Copy link
Member

bradzacher commented Mar 13, 2023

need to fix up this case:

# Conflicts:
#	packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-abstract-with-value/snapshots/1-TSESTree-AST.shot
#	packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-abstract-with-value/snapshots/2-TSESTree-Tokens.shot
#	packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-abstract-with-value/snapshots/3-Babel-AST.shot
#	packages/ast-spec/src/element/AccessorProperty/fixtures/modifier-abstract-with-value/snapshots/4-Babel-Tokens.shot
@nx-cloud
Copy link

nx-cloud bot commented Mar 14, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3d509cf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #6613 (3d509cf) into v6 (62d6230) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #6613      +/-   ##
==========================================
- Coverage   85.25%   85.23%   -0.02%     
==========================================
  Files         372      372              
  Lines       12727    12729       +2     
  Branches     3782     3783       +1     
==========================================
  Hits        10850    10850              
- Misses       1498     1499       +1     
- Partials      379      380       +1     
Flag Coverage Δ
unittest 85.23% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 31.03% <33.33%> (-0.09%) ⬇️

@bradzacher bradzacher added the enhancement New feature or request label Mar 15, 2023
@bradzacher bradzacher changed the title feat: throw errors when abstract property has initializer feat(typescript-estree): throw errors when abstract property has initializer Mar 17, 2023
@bradzacher bradzacher merged commit dcdbc76 into typescript-eslint:v6 Mar 17, 2023
43 of 44 checks passed
@fisker fisker deleted the abstract-property-initializer branch March 17, 2023 01:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants