Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): allow parser@^6.0.0 #6630


Copy link

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 14, 2023

PR Checklist


Without this, on npm i:

joshgoldberg ~/repos/TypeScript $ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: typescript@5.1.0
npm ERR! Found: @typescript-eslint/parser@6.0.0-alpha.81
npm ERR! node_modules/@typescript-eslint/parser
npm ERR!   dev @typescript-eslint/parser@"^6.0.0-alpha.81" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @typescript-eslint/parser@"^5.0.0" from @typescript-eslint/eslint-plugin@6.0.0-alpha.81
npm ERR! node_modules/@typescript-eslint/eslint-plugin
npm ERR!   dev @typescript-eslint/eslint-plugin@"^6.0.0-alpha.81" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/josh/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/josh/.npm/_logs/2023-03-14T07_47_53_197Z-debug-0.log

Copy link

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on

@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Mar 14, 2023
Copy link

netlify bot commented Mar 14, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d2ae564
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

nx-cloud bot commented Mar 14, 2023

Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit forget to do this every single major lol.

Also this range won't match the RC version I think?

This reverts commit ed97163.
@JoshuaKGoldberg JoshuaKGoldberg merged commit 92908bd into typescript-eslint:v6 Mar 14, 2023
34 of 37 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the eslint-plugin-allow-parser-v6 branch March 14, 2023 18:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants