Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): allow writing to deprecated node properties #6670


Copy link

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 18, 2023

PR Checklist


In the node's Object.defineProperty accessor descriptor, it's now given a setter that sets it to a data descriptor. See terminology on

Copy link

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on

Copy link

netlify bot commented Mar 18, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 71b51c9
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

nx-cloud bot commented Mar 18, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 71b51c9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

Copy link
Member Author

JoshuaKGoldberg commented Mar 19, 2023

(converting to draft as I have to poke at the website build - I probably messed up something in conversion with this scope...)

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft March 19, 2023 14:18
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #6670 (b7c9677) into v6 (28a64b5) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b7c9677 differs from pull request most recent head 71b51c9. Consider uploading reports for the commit 71b51c9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##               v6    #6670   +/-   ##
  Coverage   85.23%   85.23%           
  Files         372      372           
  Lines       12729    12729           
  Branches     3783     3782    -1     
  Hits        10850    10850           
  Misses       1499     1499           
  Partials      380      380           
Flag Coverage Δ
unittest 85.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 31.03% <100.00%> (ø)

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review March 19, 2023 15:33
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team March 19, 2023 15:40
@bradzacher bradzacher added the bug Something isn't working label Mar 20, 2023
@bradzacher bradzacher added this to the 6.0.0 milestone Mar 20, 2023
packages/typescript-estree/src/convert.ts Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg merged commit 6652ebe into typescript-eslint:v6 Mar 20, 2023
37 of 40 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the convert-writable-properties branch March 20, 2023 12:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants