Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): forbid override on non-constructor function/methods #6729

merged 1 commit into from Mar 21, 2023


Copy link

@fisker fisker commented Mar 21, 2023

PR Checklist


Missed in #6615

Copy link

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on

Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 30f9768
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

nx-cloud bot commented Mar 21, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 30f9768. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

@fisker fisker marked this pull request as ready for review March 21, 2023 11:01
@bradzacher bradzacher added this to the 6.0.0 milestone Mar 21, 2023
Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@bradzacher bradzacher changed the title fix: forbid override on non-constructor function/methods fix(typescript-estree): forbid override on non-constructor function/methods Mar 21, 2023
@bradzacher bradzacher merged commit 2f3638f into typescript-eslint:v6 Mar 21, 2023
41 of 43 checks passed
@fisker fisker deleted the override branch March 21, 2023 11:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants