Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): [playground] add tabs to ast viewer and update design #6735

merged 2 commits into from Mar 27, 2023


Copy link

@armano2 armano2 commented Mar 22, 2023

PR Checklist


migrate tabs changes from #6656

notable changes:

  • right panel uses tabs instead of dropdown in options
  • design has been updated to use styles from button/button-group






Copy link

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on

Copy link

netlify bot commented Mar 22, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1370e4a
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

nx-cloud bot commented Mar 22, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1370e4a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #6735 (1370e4a) into v6 (f84bf4a) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##               v6    #6735      +/-   ##
- Coverage   87.40%   87.36%   -0.04%     
  Files         373      373              
  Lines       12844    12800      -44     
  Branches     3811     3793      -18     
- Hits        11226    11183      -43     
  Misses       1232     1232              
+ Partials      386      385       -1     
Flag Coverage Δ
unittest 87.36% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🔥

packages/website/src/components/config.ts Show resolved Hide resolved
@armano2 armano2 changed the title chore(website): update design of tabs and add tabs to right panel chore(website): [playground] ad tabs to ast viewer and update design Mar 27, 2023
@armano2 armano2 changed the title chore(website): [playground] ad tabs to ast viewer and update design chore(website): [playground] add tabs to ast viewer and update design Mar 27, 2023
@armano2 armano2 merged commit 118a409 into v6 Mar 27, 2023
47 checks passed
@armano2 armano2 deleted the chore/website-editor-tabs branch March 27, 2023 07:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants