Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [member-ordering] account for repeated names #6864



Copy link

PR Checklist


naturalOutOfOrder should always return false if the names being compared are the same.

Copy link

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on

Copy link

netlify bot commented Apr 8, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 83c62c2
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(eslint-plugin) [member-ordering] account for repeated names fix(eslint-plugin): [member-ordering] account for repeated names Apr 8, 2023
Copy link

nx-cloud bot commented Apr 8, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 83c62c2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 34 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #6864 (b783b1e) into main (e5d668c) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head b783b1e differs from pull request most recent head 83c62c2. Consider uploading reports for the commit 83c62c2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6864      +/-   ##
- Coverage   87.47%   87.37%   -0.11%     
  Files         379      386       +7     
  Lines       13234    13192      -42     
  Branches     3907     3868      -39     
- Hits        11577    11526      -51     
- Misses       1279     1300      +21     
+ Partials      378      366      -12     
Flag Coverage Δ
unittest 87.37% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/member-ordering.ts 96.46% <100.00%> (+0.03%) ⬆️

... and 180 files with indirect coverage changes

@bradzacher bradzacher added the bug Something isn't working label Apr 10, 2023
Copy link

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

@bradzacher bradzacher added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Jul 18, 2023
@bradzacher bradzacher merged commit d207b59 into typescript-eslint:main Jul 18, 2023
40 of 47 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the member-ordering-equal-names branch July 18, 2023 11:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

Bug: [member-ordering] false-positive error when order is set to natural or natural-case-insensitive
3 participants