Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [comma-dangle] fixed crash from undefined predicate.ignore #7223

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Reverts ignore from undefined back to () => {}, and adds a test case for the crash.

Shoutout+thanks to @erik-slovak for reporting in 42fe29f#r121427176 & @sharpdressedcodes for pointing out the lack of unit test! 馃檶

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


馃檹 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for typescript-eslint ready!

Name Link
馃敤 Latest commit e97cea0
馃攳 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64b1669ff76a41000831e189
馃槑 Deploy Preview https://deploy-preview-7223--typescript-eslint.netlify.app
馃摫 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Jul 14, 2023

鈽侊笍 Nx Cloud Report

CI is running/has finished running commands for commit e97cea0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

馃搨 See all runs for this branch


鉁 Successfully ran 31 targets

Sent with 馃拰 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg merged commit d368164 into typescript-eslint:main Jul 15, 2023
44 of 46 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the comma-dangle-ignore-function branch July 15, 2023 13:03
@sharpdressedcodes
Copy link

Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants