Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin)!: change recommended config #729

Merged
merged 22 commits into from Aug 13, 2019

Conversation

@bradzacher
Copy link
Member

commented Jul 20, 2019

BREAKING CHANGE: recommended config changes are considered breaking

See #651 for more info about what was included and why

Fixes #651
Fixes #433
Fixes #201
Fixes #493
Fixes #759
Fixes #822

feat(eslint-plugin): change recommended config
BREAKING: recommended config changes are considered breaking

@bradzacher bradzacher added this to the 2.0.0 milestone Jul 20, 2019

@bradzacher bradzacher referenced this pull request Jul 20, 2019
14 of 14 tasks complete

@bradzacher bradzacher changed the title feat(eslint-plugin): change recommended config feat(eslint-plugin)!: change recommended config Jul 21, 2019

bradzacher added some commits Jul 21, 2019

Merge branch 'master' into v2-update-recommended
# Conflicts:
#	packages/eslint-plugin/src/configs/base.json
#	packages/eslint-plugin/src/configs/recommended.json
Merge branch 'master' into v2-update-recommended
# Conflicts:
#	packages/eslint-plugin/README.md
#	packages/eslint-plugin/src/configs/base.json
#	packages/eslint-plugin/src/configs/recommended.json
#	packages/eslint-plugin/src/rules/no-triple-slash-reference.ts
#	packages/eslint-plugin/src/rules/prefer-interface.ts
Merge branch 'master' into v2-update-recommended
# Conflicts:
#	packages/eslint-plugin/README.md

bradzacher added some commits Jul 28, 2019

Merge branch 'master' into v2-update-recommended
# Conflicts:
#	.eslintrc.json
#	packages/eslint-plugin/src/rules/camelcase.ts
#	packages/eslint-plugin/src/rules/indent-new-do-not-use/index.ts
#	packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts
#	packages/eslint-plugin/tests/rules/indent/utils.ts
#	packages/eslint-plugin/tools/validate-docs/validate-table-structure.ts
#	packages/parser/src/analyze-scope.ts
#	packages/typescript-estree/tests/lib/semanticInfo.ts
#	yarn.lock
.eslintrc.js Show resolved Hide resolved
@codecov

This comment has been minimized.

Copy link

commented Jul 31, 2019

Codecov Report

Merging #729 into master will decrease coverage by 0.01%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
- Coverage   94.21%   94.19%   -0.02%     
==========================================
  Files         112      112              
  Lines        4821     4825       +4     
  Branches     1336     1338       +2     
==========================================
+ Hits         4542     4545       +3     
- Misses        159      160       +1     
  Partials      120      120
Impacted Files Coverage Δ
.../eslint-plugin/src/rules/no-useless-constructor.ts 100% <ø> (ø) ⬆️
...ackages/eslint-plugin/src/rules/prefer-includes.ts 100% <ø> (ø) ⬆️
packages/eslint-plugin/src/rules/ban-types.ts 100% <ø> (ø) ⬆️
packages/parser/src/scope/scope-manager.ts 100% <ø> (ø) ⬆️
...ages/eslint-plugin/src/rules/no-require-imports.ts 100% <ø> (ø) ⬆️
...slint-plugin/src/rules/no-unnecessary-qualifier.ts 96.07% <ø> (ø) ⬆️
...ges/eslint-plugin/src/rules/no-misused-promises.ts 100% <ø> (ø) ⬆️
packages/eslint-plugin-tslint/src/custom-linter.ts 100% <ø> (ø) ⬆️
.../eslint-plugin/src/rules/triple-slash-reference.ts 90% <ø> (ø) ⬆️
...kages/eslint-plugin/src/rules/class-name-casing.ts 85.71% <ø> (ø) ⬆️
... and 60 more
@glen-84

This comment has been minimized.

Copy link

commented Aug 8, 2019

@bradzacher Should the documentation also be updated?

bradzacher added some commits Aug 8, 2019

@JamesHenry
Copy link
Member

left a comment

This contains some important updates to defaults of rules etc, and in general has a large diff, so I'm going to merge it and make the updates we discussed in a follow up.

Thanks again for doing this!

@JamesHenry JamesHenry merged commit 428567d into master Aug 13, 2019

6 of 7 checks passed

codecov/patch 89.47% of diff hit (target 90%)
Details
Semantic Pull Request ready to be merged or rebased
Details
codecov/project 94.19% (-0.02%) compared to de6cc1d
Details
typescript-eslint.typescript-eslint Build #20190813.2 succeeded
Details
typescript-eslint.typescript-eslint (Primary code validation and tests) Primary code validation and tests succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_10_x) Run unit tests on other Node.js versions node_10_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_8_x) Run unit tests on other Node.js versions node_8_x succeeded
Details

@JamesHenry JamesHenry deleted the v2-update-recommended branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.