Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scope-manager): correct decorators(.length) check in ClassVisitor for methods #7334


Copy link

PR Checklist


Adds a missing .decorators check and updates snapshots.

I tried for a bit to get a @typescript-eslint/consistent-type-imports unit test to fail without the change, but couldn't.

Copy link

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on

Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2b8ed41
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jul 27, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2b8ed41. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 35 targets

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the bug Something isn't working label Jul 28, 2023
bradzacher previously approved these changes Jul 28, 2023
Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add the issue snippet as a test case to the consistent-type-imports rule?

Copy link
Member Author

I can't get it to fail on main 😕 Aha! I was missing parserOptions: { emitDecoratorMetadata: true }. Thanks for the prod - will add.

@JoshuaKGoldberg JoshuaKGoldberg merged commit abbb6c2 into typescript-eslint:main Jul 29, 2023
48 of 49 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the class-visitor-method-decorators-check branch July 29, 2023 00:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet
2 participants