New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: the big package renaming #82

Merged
merged 7 commits into from Jan 19, 2019

Conversation

Projects
None yet
2 participants
@JamesHenry
Copy link
Member

JamesHenry commented Jan 19, 2019

Consolidate everything under their new scoped names, yes this is unreviewable, but fortunately it is a one-off! :)

Better docs will follow after this before 1.0.0 tomorrow

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #82   +/-   ##
======================================
  Coverage    94.8%   94.8%           
======================================
  Files          48      48           
  Lines        2465    2465           
  Branches      380     380           
======================================
  Hits         2337    2337           
  Misses         77      77           
  Partials       51      51
Impacted Files Coverage Δ
...slint-plugin/lib/rules/prefer-namespace-keyword.js 100% <ø> (ø)
...eslint-plugin/lib/rules/no-parameter-properties.js 100% <ø> (ø)
packages/parser/src/visitor-keys.ts 100% <ø> (ø)
packages/eslint-plugin/lib/rules/camelcase.js 96.15% <ø> (ø)
.../eslint-plugin/lib/rules/member-delimiter-style.js 100% <ø> (ø)
...lugin/lib/rules/no-angle-bracket-type-assertion.js 100% <ø> (ø)
packages/eslint-plugin/lib/rules/no-namespace.js 100% <ø> (ø)
...ges/eslint-plugin/lib/rules/no-inferrable-types.js 92.1% <ø> (ø)
...ackages/eslint-plugin/lib/rules/member-ordering.js 96.72% <ø> (ø)
...s/eslint-plugin/lib/rules/no-non-null-assertion.js 100% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78a8b7c...5d9c2f8. Read the comment docs.

@@ -40,7 +40,7 @@ ruleTester.run('tslint/config', rules.config, {
valid: [
{
code: 'var foo = true;',
parser: 'typescript-eslint-parser',
parser: '@typescript-eslint/parser',

This comment has been minimized.

@armano2

armano2 Jan 19, 2019

Member

can you move parser and parserOptions to

const ruleTester = new RuleTester();
const ruleTester = new RuleTester({
  parserOptions: {
    ecmaVersion: 6,
    sourceType: 'module',
    ecmaFeatures: {}
  },
  parser: '@typescript-eslint/parser',
  project: './tests/tsconfig.json'
});
// their work around exposing the parser. They may require that there be a project config field in
// the eslint config, in which case we should check and/or report that here appropriately.
throw new Error(
'This rule requires you to use `eslint-plugin-typescript/parser`.'
'This rule requires you to use `@typescript-eslint/eslint-plugin/parser`.'

This comment has been minimized.

@armano2

armano2 Jan 19, 2019

Member
Suggested change Beta
'This rule requires you to use `@typescript-eslint/eslint-plugin/parser`.'
`You must provide a value for the "parserOptions.project" property for @typescript-eslint/parser`

its same message as in plugin-tslint

@JamesHenry JamesHenry merged commit 132c078 into master Jan 19, 2019

2 checks passed

codecov/patch 100% of diff hit (target 90%)
Details
codecov/project 94.8% (+0%) compared to 78a8b7c
Details

@JamesHenry JamesHenry deleted the names branch Jan 19, 2019

@JamesHenry

This comment has been minimized.

Copy link
Member Author

JamesHenry commented Jan 19, 2019

@armano2 Thanks I've noted down your points, adding them to my follow up PR - lots of tweaks to make yet anyway and I don't want anyone starting any WIP without the big reorg/renaming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment