Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(eslint-plugin)!: recommended-requiring-type-checking config #846
BREAKING CHANGE: removed some rules from recommended config
P.S. TODO in follow up (lower priority because integration test will catch the violations that matter), add some kind of check (maybe we should create a new package for lint rules which only apply to the monorepo and which we don't publish?) to ensure that we correctly mark rules requiring type-checking with
Thanks for the PR, @JamesHenry!
typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.
The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.
Aug 13, 2019
bradzacher left a comment •
Awesome! Everything LGTM!
Two suggestions and then I think this can be merged for the full 2.0 release
Probs should update the configs readme with the new config.
Would be awesome if you could update the doc validator so it supports the new prop you added. Might be a good idea to use this to validate that the boolean flag is set correctly.