Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: eliminate spurious Prettier warnings on Windows #869

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@octogonz
Copy link
Contributor

commented Aug 15, 2019

The Git commit hook always fails on Windows because the EOL character is not what Prettier expects it to be.

@typescript-eslint

This comment has been minimized.

Copy link

commented Aug 15, 2019

Thanks for the PR, @octogonz!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@bradzacher
Copy link
Member

left a comment

sounds like a good idea. thanks for that!

@bradzacher bradzacher merged commit 32d3745 into typescript-eslint:master Aug 16, 2019

5 checks passed

Semantic Pull Request ready to be squashed
Details
typescript-eslint.typescript-eslint Build #20190815.12 succeeded
Details
typescript-eslint.typescript-eslint (Primary code validation and tests) Primary code validation and tests succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_10_x) Run unit tests on other Node.js versions node_10_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_8_x) Run unit tests on other Node.js versions node_8_x succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.