Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(typescript-estree): document that duplicate filenames are unsupported #957

Merged
merged 5 commits into from Sep 12, 2019

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Sep 6, 2019

Closes #955

I also added types for something because I hated seeing the anys.
Added a vscode launch option that I used to debug this issue.

@bradzacher bradzacher added the bug Something isn't working label Sep 6, 2019
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@bradzacher bradzacher changed the title fix(typescript-estree): allow files in the same dir with the same name chore(typescript-estree): minor code cleanup Sep 7, 2019
@bradzacher bradzacher changed the title chore(typescript-estree): minor code cleanup docs(typescript-estree): document that duplicate filenames are unsupported Sep 7, 2019
@codecov
Copy link

codecov bot commented Sep 7, 2019

Codecov Report

Merging #957 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #957      +/-   ##
==========================================
- Coverage   94.08%   94.08%   -0.01%     
==========================================
  Files         114      114              
  Lines        4957     4956       -1     
  Branches     1382     1382              
==========================================
- Hits         4664     4663       -1     
  Misses        166      166              
  Partials      127      127
Impacted Files Coverage Δ
packages/typescript-estree/src/tsconfig-parser.ts 87.83% <100%> (-0.17%) ⬇️

@bradzacher bradzacher added documentation Documentation ("docs") that needs adding/updating and removed bug Something isn't working labels Sep 7, 2019
@bradzacher bradzacher marked this pull request as ready for review September 7, 2019 06:08
@JamesHenry JamesHenry merged commit b49dbfd into master Sep 12, 2019
@JamesHenry JamesHenry deleted the 955-duplicate-filenames branch September 12, 2019 08:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files with the same name (without extensions) are not parsable
2 participants