fix apply refactoring returning -1 positions in ranges #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typescript appears to be sending 0, 0 ranges when providing edit for creating new file, even though the positions are supposed to be 1-based. Fixes #501
rchl
added a commit
that referenced
this pull request
Jun 24, 2022
rchl
added a commit
that referenced
this pull request
Jul 23, 2022
* master: chore(deps): add renovate configuration chore(lint): enable "no-constant-binary-expression" rule chore(deps): bump commander from 9.3.0 to 9.4.0 (#527) chore(deps-dev): bump @typescript-eslint/eslint-plugin from 5.28.0 to 5.30.7 (#521) chore(deps-dev): bump @typescript-eslint/parser from 5.30.6 to 5.30.7 (#526) chore(deps-dev): bump concurrently from 7.2.2 to 7.3.0 (#523) chore(deps-dev): bump eslint from 8.18.0 to 8.20.0 (#522) chore(deps-dev): bump @typescript-eslint/parser from 5.27.1 to 5.30.6 (#515) chore(deps-dev): bump ts-node from 10.8.1 to 10.9.1 (#518) chore(master): release 0.11.2 (#503) chore(deps-dev): bump eslint from 8.17.0 to 8.18.0 (#498) chore(deps-dev): bump @typescript-eslint/eslint-plugin from 5.27.1 to 5.28.0 (#499) chore(deps-dev): bump concurrently from 7.2.1 to 7.2.2 (#500) fix: apply refactoring returns -1 positions in ranges (#502) chore(master): release 0.11.1 (#494) fix: completion for strings with trigger character (#492)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript appears to be sending 0, 0 ranges when providing edit for
creating new file, even though the positions are supposed to be 1-based.
Fixes #501