Skip to content

Conversation

@morenol
Copy link
Collaborator

@morenol morenol commented Aug 1, 2025

Change Summary

PR Checklist

Closes #46

@morenol morenol requested a review from Copilot August 1, 2025 23:14
@morenol morenol mentioned this pull request Aug 1, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a GitHub Actions workflow for publishing the typesense Rust crates to crates.io and modernizes the Cargo workspace configuration. The changes prepare the project for automated publishing with proper workspace management.

  • Introduces a GitHub Actions workflow that publishes all three crates (typesense_derive, typesense_codegen, typesense) to crates.io when version tags are pushed
  • Modernizes Cargo workspace configuration with shared package metadata and dependency management
  • Updates individual crate configurations to use workspace-shared values and corrects version inconsistencies

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/release.yml Adds automated publishing workflow for crates.io
Cargo.toml Configures workspace with shared package metadata and dependencies
typesense/Cargo.toml Updates to use workspace configuration and fixes description
typesense_derive/Cargo.toml Migrates to workspace-shared configuration
typesense_codegen/Cargo.toml Updates version and migrates to workspace configuration
typesense_derive/src/lib.rs Minor code formatting and style improvements
Comments suppressed due to low confidence (3)

Cargo.toml:8

  • Cargo resolver version "3" does not exist. The latest resolver version is "2". This should be changed to resolver = "2".
resolver = "3"

Cargo.toml:12

  • Rust edition "2024" does not exist yet. The latest stable edition is "2021". This should be changed to edition = "2021".
edition = "2024"

typesense_derive/src/lib.rs:82

  • [nitpick] The variable name g is not descriptive. Consider using a more meaningful name like gen or generated_code to improve code readability.
    let g = quote! {

@morenol morenol requested a review from jasonbosco August 1, 2025 23:19
@jasonbosco jasonbosco merged commit 33fbd24 into main Aug 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish on Crates.io

3 participants