-
Notifications
You must be signed in to change notification settings - Fork 397
Feat/update project tooling #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CC @jotamorais, @rmuchall some tests are still failing. @rmuchall I use the same test in most of the places which you wrote, how did you manage to make them pass? |
|
I took a quick look at the branch /feat/update-project-tooling and I can see 11 failed tests. Scanning through the errors they look like bugs in the tests themselves (or perhaps just changes in the routing-controllers functionality where the test code hasn't been updated to match). I don't see any tests specifically failing due to the use of Jest/Axios. |
Yes but as I mentioned, the tests are shamelessly copied from your PR, so I would expect them to pass.
I don't think that much functionality has changed. Anyway, thanks for the look! I will look into those when I have time (they look nasty, concurrency issues) I just hoped I have missed some flag or something :D |
|
Are you seeing the same amount of failed test? (11) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
|
Why did we merge this with failing tests? |
Description
Add the shared project tooling from the other repository
Checklist
Update index.md)develop)npm run prettier:checkpassesnpm run lint:checkpassesFixes
fixes #[issue number], fixes #[issue number]