Skip to content

Conversation

@NoNameProvided
Copy link
Member

@NoNameProvided NoNameProvided commented Aug 9, 2020

Description

Add the shared project tooling from the other repository

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #[issue number], fixes #[issue number]

@NoNameProvided
Copy link
Member Author

CC @jotamorais, @rmuchall some tests are still failing. @rmuchall I use the same test in most of the places which you wrote, how did you manage to make them pass?

@rmuchall
Copy link

rmuchall commented Aug 9, 2020

I took a quick look at the branch /feat/update-project-tooling and I can see 11 failed tests.
Do you get the same results?

Scanning through the errors they look like bugs in the tests themselves (or perhaps just changes in the routing-controllers functionality where the test code hasn't been updated to match). I don't see any tests specifically failing due to the use of Jest/Axios.

@NoNameProvided
Copy link
Member Author

Scanning through the errors they look like bugs in the tests themselves

Yes but as I mentioned, the tests are shamelessly copied from your PR, so I would expect them to pass.

(or perhaps just changes in the routing-controllers functionality where the test code hasn't been updated to match)

I don't think that much functionality has changed.

Anyway, thanks for the look! I will look into those when I have time (they look nasty, concurrency issues) I just hoped I have missed some flag or something :D

@rmuchall
Copy link

rmuchall commented Aug 9, 2020

Are you seeing the same amount of failed test? (11)
If they look like concurrency issues then it might be related to the "runInBand" issue we encountered.
See here for details: #553 (comment)

@jotamorais jotamorais merged commit 0787932 into develop Dec 10, 2020
@jotamorais jotamorais deleted the feat/update-project-tooling branch December 10, 2020 15:36
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2021
@NoNameProvided
Copy link
Member Author

Why did we merge this with failing tests?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants