Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted exclude_dflt argument on the examples #23

Merged
merged 1 commit into from May 2, 2020

Conversation

jmsole
Copy link
Contributor

@jmsole jmsole commented Jun 26, 2018

Deleted exclude_dflt argument on the examples as it is not really needed to make them work and can lead to misconceptions of what the argument is used for. From examples around the web and in talking to people it seems a lot of people think exclude_dflt is meant to exclude lookups that come after it from languagesystem DFLT dflt or from script XXX; language dflt;, when in reality it is the other way around; it's meant to exclude any lookups defined within DFLT or dflt from the language the argument is added to.

The Feature File Syntax documentation has a good example of this (Example 2), for once:

feature liga {
           # start of default rules that are applied under all language systems.
          lookup HAS_I {
           sub f f i by f_f_i;
           sub f i by f_i;
          } HAS_I;
 
          lookup NO_I {
           sub f f l by f_f_l;
           sub f f by f_f;
          } NO_I;
           
# end of default rules that are applied under all language systems.
 
     script latn;
         language dflt;              
# default lookup for latn included under all languages for the latn script
           
         sub f l by f_l;
         language DEU;              
# default lookups included under the DEU language..
         sub s s by germandbls;   # This is also included.
         language TRK exclude_dflt;   # default lookups are excluded.
          lookup NO_I;             #Only this lookup is included under the TRK language
 
     script cyrl;
        language SRB;
          sub c t by c_t; # this rule will apply only under script cyrl language SRB.
  } liga;

…ded to make them work and can lead to misconceptions of what it is used for.
@typesupply typesupply merged commit d276478 into typesupply:master May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants