Test case and fix for Issue 1027. Add Google Inc. as contributor. #1038
Conversation
docs/manual/troubleshooting.tex
Outdated
| @@ -1124,6 +1124,7 @@ \section{Credits and changelog\label{credits}} | |||
| David Lazar, | |||
| David McArthur, | |||
| Eric Spishak, | |||
| Google Inc. (via @wmdietlGC), | |||
There was a problem hiding this comment.
Nit: please put \ after . to signal to LaTeX that this period doesn't end a sentence.
| TypeMirror enclosingType = ElementUtils.enclosingClass(ele).asType(); | ||
| FlowExpressionContext parameterContext = | ||
| FlowExpressionContext.buildContextForMethodDeclaration( | ||
| methodTree, enclosingType, factory.getContext()); | ||
| standardizeDoNotUseLocals(parameterContext, path, type); | ||
| break; | ||
| } else { | ||
| // If there is no enclosing method, then the parameter is a parameter to a lambda |
There was a problem hiding this comment.
It's not that there is no enclosing method, but that the nearest enclosing thing was a lambda rather than a method. Am I right about that?
(I realize that you copied the comment from the existing code, but I think it can still be improved.)
There was a problem hiding this comment.
Yes, there might still be a method around the lambda, but the most enclosing tree was a lambda.
I've added short comments to both branches.
I think enclTree will always be non-null; I can't think of a way to get a parameter without either of these two cases being true. We'll see if we ever get a NPE on the if condition.
|
Looks great, thanks a lot! |
No description provided.