Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo on docs/README.md #1037

Merged
merged 1 commit into from Sep 14, 2021
Merged

Conversation

shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Sep 5, 2021

Hello, this PR fixes a tiny typo in docs/README.md.

I think the --only parameter of npm ci should be --only=production same as Line 254.

@typicode
Copy link
Owner

@typicode typicode commented Sep 7, 2021

hello, good catch 👍

Actually it seems to be deprecated (https://docs.npmjs.com/cli/v7/using-npm/config#only) in favor of --omit=dev.

Could you update this PR to replace --only with --omit in the docs?

@shuuji3
Copy link
Contributor Author

@shuuji3 shuuji3 commented Sep 7, 2021

@typicode You are right.🙂 I've updated the PR to use --omit.

@typicode
Copy link
Owner

@typicode typicode commented Sep 14, 2021

Thank you :)

@typicode typicode merged commit c86dde9 into typicode:main Sep 14, 2021
@shuuji3 shuuji3 deleted the fix-docs-typo branch Sep 14, 2021
@shuuji3
Copy link
Contributor Author

@shuuji3 shuuji3 commented Sep 14, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants