Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(shell): add trailing newlines #870

Merged
merged 1 commit into from Feb 22, 2021
Merged

style(shell): add trailing newlines #870

merged 1 commit into from Feb 22, 2021

Conversation

@valtlai
Copy link
Contributor

@valtlai valtlai commented Feb 14, 2021

Adds trailing newlines to files generated by the install and add commands.

@typicode
Copy link
Owner

@typicode typicode commented Feb 21, 2021

Thanks for the PR, how could I reproduce the issue locally?

Adds trailing newlines to files generated by the `install` and `add` commands.
@valtlai
Copy link
Contributor Author

@valtlai valtlai commented Feb 22, 2021

@typicode

Steps to reproduce:

  1. Make sure that there’s no a .husky directory.
  2. Run npx husky init.
  3. Look at the files .husky/.gitignore and .husky/pre-commit: they don’t have a trailing newline at the end.

It’s a very common practice to have a newline at the end of a file. I think Husky should align with that.

@typicode typicode changed the title Add trailing newlines fix(cli): add trailing newline to created files Feb 22, 2021
@typicode typicode changed the title fix(cli): add trailing newline to created files style(shell): add trailing newlines (#870) Feb 22, 2021
@typicode typicode changed the title style(shell): add trailing newlines (#870) style(shell): add trailing newlines Feb 22, 2021
@typicode typicode merged commit 7387773 into typicode:main Feb 22, 2021
1 check failed
1 check failed
continuous-integration/appveyor/pr AppVeyor build failed
Details
@valtlai valtlai deleted the valtlai:newlines branch Feb 22, 2021
This was referenced Mar 16, 2021
chalkygames123 added a commit to chalkygames123/stylelint-config that referenced this pull request Mar 20, 2021
chalkygames123 added a commit to chalkygames123/stylelint-config that referenced this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants