Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - Updated documentation regarding pagination API from per_page to _limit #1505

Closed
wants to merge 1 commit into from

Conversation

ZynthCode
Copy link

Updated documentation regarding pagination API from per_page to _limit

Updated documentation regarding pagination API from per_page to _limit
@ZynthCode
Copy link
Author

I spent probably 10-30 minutes scratching my head trying to figure out why _page_size or page_size did not work, only to dig deeper and find it is now named _limit 😅

@typicode
Copy link
Owner

typicode commented Jan 28, 2024

Thank you for the PR.

_per_page should work, otherwise it's a bug.

_limit should be used with _start.

@ZynthCode
Copy link
Author

ZynthCode commented Jan 28, 2024

Thank you for the PR.

_per_page should work, otherwise it's a bug.

_limit should be used with _start.

This was tested on https://jsonplaceholder.typicode.com/posts?_page=1&_limit=5

To achieve pagination I had to use _page with _limit, since _per_page does not currently work there, which lead me to believe that it was deprecated and removed. Here is a test: https://jsonplaceholder.typicode.com/posts?_page=1&_per_page=5

If the jsonplaceholder.typicode.com is not up to date, or does not reflect the changes on this repository, I suspect you can close this as a non-issue since the issue may be elsewhere. 😺

@typicode
Copy link
Owner

It's running 0.17and will continue to do so to avoid breaking stuff.

Closing then 👍

@ZynthCode ZynthCode closed this Jan 28, 2024
@ZynthCode ZynthCode deleted the pagination_readme_patch branch January 28, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants