New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser field (and others?) may need refinement #9

Open
typicode opened this Issue Oct 5, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@typicode
Owner

typicode commented Oct 5, 2018

Browser field (and others?) may need to refined:
https://twitter.com/AndaristRake/status/1048164567698886656

Thanks a lot to @Andarist for pointing that out! 馃憤

@typicode typicode added the help wanted label Oct 5, 2018

@Andarist

This comment has been minimized.

Show comment
Hide comment
@Andarist

Andarist Oct 5, 2018

Im not sure if the thing i have said about relative paths in browser field is common for all tools, but I had to fix it at least once for webpack - andreypopp/react-textarea-autosize@8666125

You might want to tag this issue as Hacktoberfest.

Andarist commented Oct 5, 2018

Im not sure if the thing i have said about relative paths in browser field is common for all tools, but I had to fix it at least once for webpack - andreypopp/react-textarea-autosize@8666125

You might want to tag this issue as Hacktoberfest.

@typicode

This comment has been minimized.

Show comment
Hide comment
@typicode

typicode Oct 11, 2018

Owner

Tagged 馃巸

Owner

typicode commented Oct 11, 2018

Tagged 馃巸

@typicode typicode changed the title from Browser field may need refinement to Browser field (and others?) may need refinement Oct 11, 2018

@HeroProtagonist

This comment has been minimized.

Show comment
Hide comment
@HeroProtagonist

HeroProtagonist Oct 15, 2018

I will have a small PR for this later today :)

HeroProtagonist commented Oct 15, 2018

I will have a small PR for this later today :)

@HeroProtagonist HeroProtagonist referenced a pull request that will close this issue Oct 16, 2018

Open

Relative path check #9 #10

@typicode

This comment has been minimized.

Show comment
Hide comment
@typicode

typicode Oct 18, 2018

Owner

@Andarist you mentioned that not all fields can be objects. Do you know/remember which ones?

Owner

typicode commented Oct 18, 2018

@Andarist you mentioned that not all fields can be objects. Do you know/remember which ones?

@Andarist

This comment has been minimized.

Show comment
Hide comment
@Andarist

Andarist Oct 18, 2018

at least main & module, I think bin can be an object, browser can be an object for sure, not sure about types, typings & es2015

Andarist commented Oct 18, 2018

at least main & module, I think bin can be an object, browser can be an object for sure, not sure about types, typings & es2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment