[BUGFIX] Process state attribute in correct tag in XLIFF 2.x files

The state attribute in XLIFF 2.x files must be on the <segment> tag,
previously it was processed on the <target> tag.

Resolves: #108032
Related: #107710
Releases: main
Change-Id: Ib41bead734c03b872900d8cd6b6b9624cd03f6d8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91482
Tested-by: Chris Müller <typo3@brotkrueml.dev>
Reviewed-by: Chris Müller <typo3@brotkrueml.dev>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: core-ci <typo3@b13.com>

Author: Julian-Schuierer

typo3/sysext/core/Classes/Localization/Loader/XliffLoader.php

@@ -230,10 +230,10 @@ private function parseXliff2(\SimpleXMLElement $root, MessageCatalogue $catalogu
                         $translation = ($target !== false && isset($target[0])) ? (string)$target[0] : (string)$source[0];
                         $catalogue->set($unitId, $translation, $domain);
                     } else {
-                        // Check approval state (XLIFF 2.0 uses 'state' attribute on target)
+                        // Check approval state (XLIFF 2.0 uses 'state' attribute on segment)
                         $approved = 'yes';
-                        if ($target !== false && isset($target[0])) {
-                            $state = (string)$target[0]['state'];
+                        if (isset($segment['state'])) {
+                            $state = (string)$segment['state'];
                             // XLIFF 2.0 states: initial, translated, reviewed, final
                             // We consider 'final' as approved, others depend on config
                             if ($state === 'initial' || $state === 'translated') {
@@ -263,8 +263,8 @@ private function parseXliff2(\SimpleXMLElement $root, MessageCatalogue $catalogu
                             $parsedTranslationElement[$formIndex] = $translation;
                         } else {
                             $approved = 'yes';
-                            if ($target !== false && isset($target[0])) {
-                                $state = (string)$target[0]['state'];
+                            if (isset($segment['state'])) {
+                                $state = (string)$segment['state'];
                                 if ($state === 'initial' || $state === 'translated') {
                                     $approved = 'no';
                                 }

typo3/sysext/core/Tests/Unit/Localization/Loader/Fixtures/de.locallang-v2.xlf

@@ -7,13 +7,13 @@
 			</segment>
 		</unit>
 		<unit id="label2">
-			<segment>
-				<target state="final">Das ist Kennung Nummer 2 [approved]</target>
+			<segment state="final">
+				<target>Das ist Kennung Nummer 2 [approved]</target>
 			</segment>
 		</unit>
 		<unit id="label3">
-			<segment>
-				<target state="translated">Das ist Kennung Nummer 3 [not approved]</target>
+			<segment state="translated">
+				<target>Das ist Kennung Nummer 3 [not approved]</target>
 			</segment>
 		</unit>
 	</file>

typo3/sysext/core/Tests/Unit/Localization/Loader/Fixtures/fr.locallang-v2.xlf

@@ -8,15 +8,15 @@
 			</segment>
 		</unit>
 		<unit id="label2">
-			<segment>
+			<segment state="final">
 				<source>This is label #2</source>
-				<target state="final">Ceci est le libellé no. 2 [approved]</target>
+				<target>Ceci est le libellé no. 2 [approved]</target>
 			</segment>
 		</unit>
 		<unit id="label3">
-			<segment>
+			<segment state="translated">
 				<source>This is label #3</source>
-				<target state="translated">Ceci est le libellé no. 3 [not approved]</target>
+				<target>Ceci est le libellé no. 3 [not approved]</target>
 			</segment>
 		</unit>
 	</file>